Forum

CS2D

Scripts

Bad argument (Nil Value)

Forums overview CS2D overview Scripts overview Log in to reply

Bad argument (Nil Value)

13 replies

Bad argument (Nil Value)

AbAeterno
User Off

Offline

27.02.12 12:45:21 am

Hello again everyone!
I'm getting the error

LUA ERROR: maps/SBV1.0.0.lua:79: Bad Argument #1 to 'msg2' (number expected, got nil)

With this:
Timer that calls the function "timefuncI"

timer(2700, "timefuncI")

And here's the function:

1
2
3
4

function timefuncI()
  msg2(id, "©000255000Hello and welcome to our Test Subjects center.") <-- Line 79
  msg2(id, "©000255000As you may have noted, you can now move in another way.")
end

What's wrong here? I think the problem is with the "id" value.

Re: Bad argument (Nil Value)

J4x
User

Offline

27.02.12 12:51:48 am

Show the whole script.

Re: Bad argument (Nil Value)

AbAeterno
User Off

Offline

27.02.12 12:54:49 am

Here:

Spoiler

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81

addhook("move","_move")
addhook("spawn","_spawn")
addhook("always","_always")
addhook("hit","_hit")

previous={}
direction={}
speed=5

function _spawn(id)
     previous[id]={player(id,"x"),player(id,"y")}
     direction[id]=nil
	 timer(2700, "timefuncI")
end

function _move(id,x,y)
     if x~=previous[id][1] or y~=previous[id][2] then
          if x>previous[id][1] then
               direction[id]=1
          elseif x<previous[id][1] then
               direction[id]=0
          elseif y>previous[id][2] then
               direction[id]=3
          elseif y<previous[id][2] then
               direction[id]=2
          end
          parse("speedmod "..id.." -50")
     end
     previous[id]={x,y}
end

function _always()
     for _,id in ipairs(player(0,"tableliving")) do
          if direction[id]~=nil then
               local x,y=0,0
               if direction[id]==0 then
                    x=-speed
               elseif direction[id]==1 then
                    x=speed
               elseif direction[id]==2 then
                    y=-speed
               elseif direction[id]==3 then
                    y=speed
               end
               parse("setpos "..id.." "..player(id,"x")+x.." "..player(id,"y")+y)
               if x==speed then
                    x=16
                    y=0
               elseif x==-speed then
                    x=-16
                    y=0
               end
               if y==speed then
                    y=16
                    x=0
               elseif y==-speed then
                    y=-16
                    x=0
               end
               if tile(math.floor((player(id,"x")+x)/32),math.floor((player(id,"y")+y)/32),"wall") then
                    parse("setpos "..id.." "..(32*player(id,"tilex")+16).." "..(32*player(id,"tiley")+16))
                    parse("speedmod "..id.." 0")
                    direction[id]=nil
                    previous[id]={player(id,"x"),player(id,"y")}
               end
          end
     end
end

function _hit()
  if (source>=1) then
    return 1
  else
    return 0
  end
end

function timefuncI()
  msg2(id, "©000255000Hello and welcome to our Test Subjects center.")
  msg2(id, "©000255000As you may have noted, you can now move in another way.")
end

Re: Bad argument (Nil Value)

Anders4000
User Off

Offline

27.02.12 01:29:28 am

You are right. You call the function with no parameters.
Got no fix for you atm. though, I'm not on a computer.

You should add parameters to your functions. Eg:

function timefuncI(id)

Do this for your _always and _hit functions too.

edited 1×, last 27.02.12 01:34:42 am

Re: Bad argument (Nil Value)

J4x
User

Offline

27.02.12 01:29:55 am

Change this

1
2
3
4

function timefuncI()
msg2(id,"©000255000Hello and welcome to our Test Subjects center.")
msg2(id,"©000255000As you may have noted, you can now move in another way.")
end

to this

1
2
3
4
5
6

function timefuncI(i)
for i=1,32 do
msg2(i,"©000255000Hello and welcome to our Test Subjects center.")
msg2(i,"©000255000As you may have noted, you can now move in another way.")
end
end

I'm not good explaining lua, I can just tell the "id" was an undefined variable or something like that...

Re: Bad argument (Nil Value)

AbAeterno
User Off

Offline

27.02.12 01:38:36 am

J4x Thank you! This worked. I now also kinda know how the "for...do" works. Thanks.

Re: Bad argument (Nil Value)

KenVo
User Off

Offline

27.02.12 02:00:57 am

I think you also have to add:

if not player(i,"exists") then return end

under timefuncI()

Re: Bad argument (Nil Value)

Anders4000
User Off

Offline

27.02.12 08:40:34 am

KenVo has written

I think you also have to add:

if not player(i,"exists") then return end

under timefuncI()

Yep, i agree.

Without it, the code is kind of sketchy.

Re: Bad argument (Nil Value)

blood2d
User Off

Offline

27.02.12 09:08:55 am

is this

timer(2700, "timefuncI",id)

1
2
3
4
5

function timefuncI(id) -- this now have a value "id"
msg2(id, "©000255000Hello and welcome to our Test Subjects center.") -- here uses the value "id"
msg2(id, "©000255000As you may have noted, you can now move in another way.")  -- here uses the value "id"
end
end

you don't especifict the id , you in the function timefunc don't type a value , but the msg2 , have a value , is "id"
, ok copy , and paste , and it finish

sorry for my bad english

Re: Bad argument (Nil Value)

EngiN33R
Moderator Off

Offline

27.02.12 01:29:04 pm

J4x has written

Change this

1
2
3
4

function timefuncI()
msg2(id,"©000255000Hello and welcome to our Test Subjects center.")
msg2(id,"©000255000As you may have noted, you can now move in another way.")
end

to this

1
2
3
4
5
6

function timefuncI(i)
for i=1,32 do
msg2(i,"©000255000Hello and welcome to our Test Subjects center.")
msg2(i,"©000255000As you may have noted, you can now move in another way.")
end
end

I'm not good explaining lua, I can just tell the "id" was an undefined variable or something like that...

Remember, for efficient scripting - never, EVER get players as

for i=1,32 do

Use this construction instead:

for _,i in pairs(player(0,"table")) do

It iterates through every value in the player table thus eliminating any possibility of non-existing players, as well as improving the efficiency.

Re: Bad argument (Nil Value)

J4x
User

Offline

27.02.12 10:51:15 pm

EngiN33R: I didn't know that, thanks for the tip.

Re: Bad argument (Nil Value)

Infinite Rain
Reviewer Off

Offline

27.02.12 11:01:26 pm

Why can't you just use msg function except of msg2 with annoying cycle?

Re: Bad argument (Nil Value)

AbAeterno
User Off

Offline

27.02.12 11:12:51 pm

Because without msg2, it will show the msg to every player, that's not what I want.

Re: Bad argument (Nil Value)

EngiN33R
Moderator Off

Offline

27.02.12 11:24:18 pm

By the way, Pwnisher's code is incorrect, now that I think about it. The for loop should be outside the function - if you even need to iterate through the players, because at the moment the function argument does nothing since it's overrided by the inner loop.